Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(netlify): remove ignore script #3092

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 5, 2024

Removes the netlify ignore check.

  • There are some cases where it would be nice if there was a preview of the changes (aka as some dependency changes).
  • The ignore script does not reduce the number of notifications and we aren't close to the build limits either

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Sep 5, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 5, 2024
@ST-DDT ST-DDT requested review from a team September 5, 2024 23:34
@ST-DDT ST-DDT self-assigned this Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit fe138ad
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66df6c15da42b50009078091
😎 Deploy Preview https://deploy-preview-3092.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (533c131) to head (fe138ad).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3092    +/-   ##
========================================
  Coverage   99.96%   99.96%            
========================================
  Files        2776     2776            
  Lines      226260   226260            
  Branches      590      942   +352     
========================================
+ Hits       226190   226191     +1     
+ Misses         70       69     -1     

see 1 file with indirect coverage changes

@Shinigami92
Copy link
Member

There are some cases where it would be nice if there was a preview of the changes (aka as some dependency changes).

So should we just remove pnpm-lock.yaml from the check?

@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 6, 2024

There are some cases where it would be nice if there was a preview of the changes (aka as some dependency changes).

So should we just remove pnpm-lock.yaml from the check?

Then it triggers in 75% of cases, so there is no need for the added complexity for no gain.
(The difference is only the locale PRs)

@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) September 9, 2024 21:43
@xDivisionByZerox xDivisionByZerox merged commit f128d77 into next Sep 9, 2024
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the infra/netlify/no-ignore branch September 9, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants