-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: switch to @stylistic/eslint-plugin #3069
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3069 +/- ##
========================================
Coverage 99.96% 99.97%
========================================
Files 2776 2776
Lines 226260 226260
Branches 941 592 -349
========================================
+ Hits 226186 226193 +7
+ Misses 74 67 -7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally by removing some blank lines, and seems to work fine
I followed the migration guide on their docs and decided to take the "easy" path and use the full combined plugin variant, where we can enable more rules in the future
It looks like there are no "recommended" rule sets as in other plugins, because their directive is more like "these are stylistic rules which are turned on individually"
closes #3068
unblocks #3064