Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: switch to @stylistic/eslint-plugin #3069

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

Shinigami92
Copy link
Member

closes #3068

unblocks #3064

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Aug 21, 2024
@Shinigami92 Shinigami92 added this to the vAnytime milestone Aug 21, 2024
@Shinigami92 Shinigami92 self-assigned this Aug 21, 2024
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit e6fe325
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66d16314ab23f70008189dae
😎 Deploy Preview https://deploy-preview-3069.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (1a94e96) to head (e6fe325).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3069    +/-   ##
========================================
  Coverage   99.96%   99.97%            
========================================
  Files        2776     2776            
  Lines      226260   226260            
  Branches      941      592   -349     
========================================
+ Hits       226186   226193     +7     
+ Misses         74       67     -7     

see 2 files with indirect coverage changes

Copy link
Member Author

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally by removing some blank lines, and seems to work fine
I followed the migration guide on their docs and decided to take the "easy" path and use the full combined plugin variant, where we can enable more rules in the future
It looks like there are no "recommended" rule sets as in other plugins, because their directive is more like "these are stylistic rules which are turned on individually"

eslint.config.js Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 marked this pull request as ready for review August 21, 2024 19:43
@Shinigami92 Shinigami92 requested a review from a team as a code owner August 21, 2024 19:43
@Shinigami92 Shinigami92 requested review from ST-DDT and a team August 30, 2024 08:40
@ST-DDT ST-DDT merged commit c850653 into next Aug 30, 2024
23 checks passed
@ST-DDT ST-DDT deleted the 3068-switching-to-stylistic-eslint-plugin branch August 30, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching to stylistic eslint plugin
3 participants