Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): migrate renovate config #3040

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 6, 2024

Mend Renovate

The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.

You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.

PLEASE NOTE: JSON5 config file migrated! All comments & trailing commas were removed.

🔕 Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.

❓ Got questions? Does something look wrong to you? Please don't hesitate to request help here.


This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner August 6, 2024 06:25
@renovate renovate bot added c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent labels Aug 6, 2024
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit f066094
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66bba83f9fd83d000856283e
😎 Deploy Preview https://deploy-preview-3040.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (8e22b63) to head (f066094).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3040   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2772     2772           
  Lines      226173   226173           
  Branches      941      940    -1     
=======================================
+ Hits       226098   226101    +3     
+ Misses         75       72    -3     

see 2 files with indirect coverage changes

.github/renovate.json5 Outdated Show resolved Hide resolved
.github/renovate.json5 Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 previously approved these changes Aug 13, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Aug 13, 2024
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope for the best.

@ST-DDT ST-DDT requested review from a team August 13, 2024 19:41
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't have any strong oppinions on the change itself, I'd like to ask if you are aware of any documentation/changelog of the change. I wasn't able to find any information about the deprecation/removal of previous field. Sorry if I'm missing something obvious,

@Shinigami92
Copy link
Member

While I don't have any strong oppinions on the change itself, I'd like to ask if you are aware of any documentation/changelog of the change. I wasn't able to find any information about the deprecation/removal of previous field. Sorry if I'm missing something obvious,

Looks like the removed / deprecated it so hardly that there is even no mentioning anymore about matchPackagePrefixes but only https://docs.renovatebot.com/configuration-options/#matchpackagenames

@Shinigami92 Shinigami92 merged commit 5a8730a into next Aug 14, 2024
23 checks passed
@Shinigami92 Shinigami92 deleted the renovate/migrate-config branch August 14, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants