Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(release): use PAT for releases #3029

Merged
merged 2 commits into from
Jul 25, 2024
Merged

infra(release): use PAT for releases #3029

merged 2 commits into from
Jul 25, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jul 24, 2024

This PR changes the release steps to use a fixed PAT instead of github-actions bot.

This should solve the issues with the CI not running automatically on push/being unable to push to vX branches.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Jul 24, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jul 24, 2024
@ST-DDT ST-DDT requested review from a team July 24, 2024 21:42
@ST-DDT ST-DDT self-assigned this Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit e5717e4
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66a176eea08fb70008cac8e4
😎 Deploy Preview https://deploy-preview-3029.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (5b32959) to head (e5717e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3029      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.02%     
==========================================
  Files        2747     2747              
  Lines      226148   226148              
  Branches      943      935       -8     
==========================================
- Hits       226079   226050      -29     
- Misses         69       98      +29     

see 1 file with indirect coverage changes

@fakerjs-bot
Copy link
Collaborator

Approved by bot to check whether it is shown as green approval.
(Write access is needed for the token to work)

@ST-DDT ST-DDT merged commit 3f70b0a into next Jul 25, 2024
25 checks passed
@ST-DDT ST-DDT deleted the feat/release-with-pat branch July 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants