-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(locale): correction of pt_PT location and person data #3020
Merged
ST-DDT
merged 6 commits into
faker-js:next
from
jeanpierrecarvalho:jpcarvalho/fix/fix-issues-on-portuguese-language
Sep 16, 2024
Merged
fix(locale): correction of pt_PT location and person data #3020
ST-DDT
merged 6 commits into
faker-js:next
from
jeanpierrecarvalho:jpcarvalho/fix/fix-issues-on-portuguese-language
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @ST-DDT, just recreated this one. Can you have a look, please? |
ST-DDT
added
m: location
Something is referring to the location module
m: person
Something is referring to the person module
labels
Jul 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3020 +/- ##
=======================================
Coverage 99.96% 99.97%
=======================================
Files 2776 2776
Lines 226262 226338 +76
Branches 940 944 +4
=======================================
+ Hits 226181 226272 +91
+ Misses 81 66 -15
|
ST-DDT
requested changes
Jul 16, 2024
Shinigami92
approved these changes
Jul 16, 2024
ST-DDT
approved these changes
Jul 16, 2024
ST-DDT
changed the title
fix: correction of pt_PT information
fix(locale): correction of pt_PT information
Jul 16, 2024
import-brain
approved these changes
Jul 17, 2024
matthewmayer
changed the title
fix(locale): correction of pt_PT information
fix(locale): correction of pt_PT location and person data
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
m: location
Something is referring to the location module
m: person
Something is referring to the person module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3020: Correction of pt_PT Information
Changes Made:
Corrected country, region names an person info in Portuguese (pt_PT) in the data file.
Details of Changes:
Additional Details:
The corrections were made to improve localization and ensure accurate representation of country names and titles in Portuguese.