-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(internet): improve ipv4 method #2992
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2992 +/- ##
=======================================
Coverage 99.96% 99.97%
=======================================
Files 2796 2796
Lines 227441 227483 +42
Branches 955 957 +2
=======================================
+ Hits 227366 227422 +56
+ Misses 75 61 -14
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly have a hard time understanding the implementation details, as I my only experience with bit manipulation is reading enum "flags" from an integer. I'm very happy for the test scenarios you provided.
Dear @ST-DDT, 😜 Thank you for your patience and contributions so far. We wanted to provide you with a brief update. We are pleased to inform you that we have addressed all the known bugs in version 9.0. We will now take a short break and resume work around October 7, 2024, to begin merging new features for v9.1, including yours. In the meantime, we hope you have a great time, and we sincerely appreciate your ongoing support and contributions. Best regards, |
LoL |
Improves the ipv4 generation options by adding parameters to configure the ip range to generate.
cidrBlock
: Declares the explicit cidr range for the ip to generate in e.g.192.168.42.0/24
. Defaults to0.0.0.0/0
.network
: Alias for well known cidr-blocks such asloopback
. Defaults toany
.Preview: internet#ipv4
Supersedes #2460