Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: cleanup clean command #2979

Merged
merged 3 commits into from
Jun 30, 2024
Merged

infra: cleanup clean command #2979

merged 3 commits into from
Jun 30, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jun 27, 2024

  • The /locale folder has been removed a long time ago
  • The docs/.vitepress/cache folder is in the gitignore, not sure what it is used for exactly

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Jun 27, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jun 27, 2024
@ST-DDT ST-DDT requested review from a team June 27, 2024 10:49
@ST-DDT ST-DDT self-assigned this Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 4eb4525
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/668190d4a3c3e00008085629
😎 Deploy Preview https://deploy-preview-2979.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (e21fcaf) to head (4eb4525).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2979   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2748     2748           
  Lines      239091   239091           
  Branches      944      943    -1     
=======================================
  Hits       238999   238999           
+ Misses         92       91    -1     
- Partials        0        1    +1     

see 3 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team June 28, 2024 18:32
@xDivisionByZerox
Copy link
Member

  • The docs/.vitepress/cache folder is in the gitignore, not sure what it is used for exactly

FFR: site-config#cachedir

@ST-DDT ST-DDT enabled auto-merge (squash) June 30, 2024 17:07
@ST-DDT ST-DDT merged commit 0679d99 into next Jun 30, 2024
23 checks passed
@ST-DDT ST-DDT deleted the infra/clean-cleanup branch June 30, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants