-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sort dependencies #2977
chore: sort dependencies #2977
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2977 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2984 2984
Lines 216057 216057
Branches 601 597 -4
==========================================
- Hits 215984 215971 -13
- Misses 73 86 +13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency updates usually gets the topic chore(deps)
from renovate. I think this should be a chore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/braindump on
If it affects src, it normally is a chore for me. Otherwise it can be an infra.
However @xDivisionByZerox is also right 🤔
IMO they are not showing up in the changelog md anyway, and so it is not so relevant
Also this is only changing order and not affecting src indirectly as a dep update could do...
/braindump off
Not sure whether this is a chore or infra.