Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sort dependencies #2977

Merged
merged 1 commit into from
Jun 28, 2024
Merged

chore: sort dependencies #2977

merged 1 commit into from
Jun 28, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jun 27, 2024

Not sure whether this is a chore or infra.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Jun 27, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jun 27, 2024
@ST-DDT ST-DDT requested review from a team June 27, 2024 07:39
@ST-DDT ST-DDT self-assigned this Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit c3de6e6
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/667d173549cc010008915ac3
😎 Deploy Preview https://deploy-preview-2977.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (49d7119) to head (c3de6e6).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2977      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2984     2984              
  Lines      216057   216057              
  Branches      601      597       -4     
==========================================
- Hits       215984   215971      -13     
- Misses         73       86      +13     

see 2 files with indirect coverage changes

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency updates usually gets the topic chore(deps) from renovate. I think this should be a chore.

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/braindump on

If it affects src, it normally is a chore for me. Otherwise it can be an infra.
However @xDivisionByZerox is also right 🤔

IMO they are not showing up in the changelog md anyway, and so it is not so relevant

Also this is only changing order and not affecting src indirectly as a dep update could do...

/braindump off

@ST-DDT ST-DDT changed the title infra: sort dependencies chore: sort dependencies Jun 27, 2024
@ST-DDT ST-DDT removed the c: infra Changes to our infrastructure or project setup label Jun 27, 2024
@ST-DDT ST-DDT merged commit 92a2f17 into next Jun 28, 2024
31 checks passed
@ST-DDT ST-DDT deleted the infra/sort/dependencies branch June 28, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants