Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: separate signature and examples #2962

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jun 20, 2024

Splits the signature and examples block into two.

Based upon:

Not sure which (additional) headers are actually useful.

Before

grafik

After

grafik

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jun 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jun 20, 2024
@ST-DDT ST-DDT requested review from a team June 20, 2024 18:57
@ST-DDT ST-DDT self-assigned this Jun 20, 2024
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 5a96a0e
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66747bac685e6a00089157de
😎 Deploy Preview https://deploy-preview-2962.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (909ea01) to head (5a96a0e).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2962      +/-   ##
==========================================
- Coverage   99.95%   99.94%   -0.02%     
==========================================
  Files        2987     2987              
  Lines      216052   216052              
  Branches      952      597     -355     
==========================================
- Hits       215963   215936      -27     
- Misses         89      116      +27     

see 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team June 21, 2024 07:04
@ST-DDT ST-DDT merged commit 5801cc5 into next Jun 21, 2024
29 checks passed
@ST-DDT ST-DDT deleted the docs/separate-signature-examples branch June 21, 2024 09:41
eLoyyyyy pushed a commit to eLoyyyyy/faker that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants