-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove potential future feature todos #2959
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: chore
PR that doesn't affect the runtime behavior
p: 1-normal
Nothing urgent
labels
Jun 20, 2024
ST-DDT
changed the title
chore: remove future feature todos
chore: remove potential future feature todos
Jun 20, 2024
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2959 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2989 2989
Lines 216085 216081 -4
Branches 950 595 -355
==========================================
- Hits 216010 215994 -16
- Misses 75 87 +12
|
xDivisionByZerox
approved these changes
Jun 20, 2024
Shinigami92
reviewed
Jun 20, 2024
Shinigami92
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind 😺
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some potential future feature TODO comments.
These are better suited as issues instead of inlien comments.
One of the TODOs has an issue already:
The other twos are features, that haven't been asked in the meantime.
If the need arises, we can create an issue and track the actual requirements
This is an attempt to solve the remaining TODOs-