Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document breaking changes for #2476 into migration guide #2935

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

matthewmayer
Copy link
Contributor

Merge the fragment into main migration guide
Any other breaking changes can now probably be merged directly without using fragments.

@matthewmayer matthewmayer requested a review from a team as a code owner June 4, 2024 05:23
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit a6a2986
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/666a8d4b21db510008635e41
😎 Deploy Preview https://deploy-preview-2935.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (c1aca55) to head (a6a2986).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2935    +/-   ##
========================================
  Coverage   99.95%   99.96%            
========================================
  Files        2987     2987            
  Lines      216037   216037            
  Branches      951      601   -350     
========================================
+ Hits       215941   215962    +21     
+ Misses         96       75    -21     

see 2 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Jun 4, 2024
@ST-DDT ST-DDT requested review from a team June 4, 2024 07:01
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jun 4, 2024
@ST-DDT ST-DDT added this to the v9.0 milestone Jun 4, 2024
Shinigami92
Shinigami92 previously approved these changes Jun 4, 2024
Co-authored-by: DivisionByZero <[email protected]>
@matthewmayer matthewmayer dismissed stale reviews from Shinigami92 and ST-DDT via 5ac8ec9 June 12, 2024 11:17
@ST-DDT ST-DDT requested review from Shinigami92, xDivisionByZerox and a team June 12, 2024 11:29
@ST-DDT ST-DDT enabled auto-merge (squash) June 13, 2024 06:11
@ST-DDT ST-DDT merged commit 2a2a132 into next Jun 13, 2024
23 checks passed
@ST-DDT ST-DDT deleted the docs/merge-2476-guide branch June 13, 2024 06:13
eLoyyyyy pushed a commit to eLoyyyyy/faker that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants