refactor(locale)!: use singular locale definition keys #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ST-DDT
requested changes
Jun 1, 2024
SaurabhXRT
changed the title
ST-DDT
changed the title
ST-DDT
added
p: 1-normal
|
Also please edit this section and add the renames: |
ST-DDT
changed the title
|
Please make sure to run |
xDivisionByZerox
requested changes
Jun 1, 2024
|
hey @matthewmayer i have some doubt i am facing error how can i connect with you ? |
ST-DDT
reviewed
Jun 5, 2024
…ttps://github.com/SaurabhXRT/faker-xrt into Use-singular-locale-definition-keys-faker-js#2911
Co-authored-by: DivisionByZero <[email protected]>
ST-DDT
reviewed
Jun 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2932 +/- ##
=======================================
Coverage 99.94% 99.95%
=======================================
Files 2987 2987
Lines 216037 216037
Branches 946 951 +5
=======================================
+ Hits 215927 215942 +15
+ Misses 110 95 -15
|
|
Two more small changes and then this is good to go. |
matthewmayer
reviewed
Jun 7, 2024
Co-authored-by: Matt Mayer <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
matthewmayer
previously approved these changes
Jun 10, 2024
ST-DDT
approved these changes
Jun 10, 2024
matthewmayer
approved these changes
Jun 11, 2024
xDivisionByZerox
approved these changes
Jun 13, 2024
|
@SaurabhXRT Thank you for your contribution ❤️ |
eLoyyyyy
pushed a commit
to eLoyyyyy/faker
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses issue #2911 by standardizing the locale definition keys to use singular naming. This change improves consistency across the codebase and aligns with the team decision discussed in the issue.
Changes Made
LoremDefinitionto use the singular keywordinstead ofwords.loremdefinition file to useword:wordstoword.SystemDefinitionto use singular keys:directory_pathstodirectory_path.mime_typestomime_type.Testing
Additional Notes
Please review the changes and let me know if any further updates are needed. This change includes a breaking change label as it modifies the locale definition keys, which might affect backward compatibility.