refactor(locale): normalize date data #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
p: 1-normal
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2902 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2977 2977
Lines 215466 215422 -44
Branches 950 948 -2
==========================================
- Hits 215394 215333 -61
- Misses 72 89 +17
|
ST-DDT
approved these changes
May 15, 2024
matthewmayer
previously requested changes
May 16, 2024
|
Team Decision
|
Shinigami92
approved these changes
May 16, 2024
import-brain
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to #2265
Normalize the entries in the
datemodule definitions in all locales.I choose this module as no data set exceedes the 1k entry limit, so all locale file changes are based on entry sorting. The git diff deletion surplus comes from deleted empty lines in between object properties in the locale entries.