Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update devcontainer image #2898

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 13, 2024

And make it easier for renovate to keep it up to date.

The old 1 refers to the major version of the image itself. The old 18 refers to the node version in that image.

Here is a list of tag for comparison:

The new shorthand 20 refers to "the latest" node 20 variant, and the docker sha pin ensures it is reproducible.

For node 22 only dev builds are available yet.

And make it easier for renovate to keep it up to date.

The old `1` refers to the major version of the image itself.
The old `18` refers to the node version in that image.

Here is a list of tag for comparison:

https://mcr.microsoft.com/v2/devcontainers/typescript-node/tags/list

The new shorthand `20` refers to "the latest" node 20 variant, and the docker sha pin ensures it is reproducible.
@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: dependencies Pull requests that adds/updates a dependency labels May 13, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 13, 2024
@ST-DDT ST-DDT requested review from a team May 13, 2024 09:09
@ST-DDT ST-DDT self-assigned this May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 6aec8dc
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66434de1715add0008e6eb5b
😎 Deploy Preview https://deploy-preview-2898.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (5ba44bc) to head (6aec8dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2898   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2977     2977           
  Lines      215466   215466           
  Branches      951      950    -1     
=======================================
+ Hits       215382   215384    +2     
+ Misses         84       82    -2     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT merged commit 044a756 into next May 14, 2024
20 checks passed
@ST-DDT ST-DDT deleted the chore/deps/devcontainers branch May 14, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants