Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): fix typo in Persian date data #2888

Merged
merged 1 commit into from
May 9, 2024
Merged

fix(locale): fix typo in Persian date data #2888

merged 1 commit into from
May 9, 2024

Conversation

hamzehazizzadeh
Copy link
Contributor

Spelling mistakes in Persian weekdays

@hamzehazizzadeh hamzehazizzadeh requested a review from a team as a code owner May 8, 2024 16:44
@netlify Netlify
Copy link

netlify bot commented May 8, 2024 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a4918e6
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/663babd3970d3d0008036b1c
😎 Deploy Preview https://deploy-preview-2888.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: date Something is referring to the date module labels May 8, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone May 8, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team May 8, 2024 17:00
@codecov Codecov
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (1eea7fe) to head (a4918e6).
Report is 7 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##             next    #2888     +/-   ##
=========================================
  Coverage   99.94%   99.95%             
=========================================
  Files        2975     2977      +2     
  Lines      214451   215466   +1015     
  Branches      942      951      +9     
=========================================
+ Hits       214339   215368   +1029     
+ Misses        112       98     -14
Files Coverage Δ
src/locales/fa/date/weekday.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT changed the title refactor(locale): normalize date data fix(locale): fix typo in Persian date data May 8, 2024
@ST-DDT ST-DDT requested a review from a team May 8, 2024 20:17
@ST-DDT ST-DDT merged commit 042c871 into faker-js:next May 9, 2024
26 checks passed
@ST-DDT
Copy link
Member

ST-DDT commented May 9, 2024

Thanks for your contribution ❤️

@hamzehazizzadeh
Copy link
Contributor Author

Your welcome ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@import-brain import-brain import-brain approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@hamzehazizzadeh hamzehazizzadeh

Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: date Something is referring to the date module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
5 participants
@hamzehazizzadeh @ST-DDT @matthewmayer @import-brain @xDivisionByZerox