Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: enable verbatimModuleSyntax #2864

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

Shinigami92
Copy link
Member

Enable verbatimModuleSyntax so type imports are used automatically when importing a type in VSCode via ctrl+space

Read also more about that here: https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax
We do not have any conflicts as we are using https://typescript-eslint.io/rules/consistent-type-imports/ anyway.

@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label Apr 29, 2024
@Shinigami92 Shinigami92 added this to the vAnytime milestone Apr 29, 2024
@Shinigami92 Shinigami92 self-assigned this Apr 29, 2024
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 29, 2024 07:10
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 6763484
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66308d76c303ad0008a50181
😎 Deploy Preview https://deploy-preview-2864.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (13dc420) to head (0659fe8).

❗ Current head 0659fe8 differs from pull request most recent head 6763484. Consider uploading reports for the commit 6763484 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             next    #2864     +/-   ##
=========================================
  Coverage   99.96%   99.96%             
=========================================
  Files        2975     2973      -2     
  Lines      214451   212501   -1950     
  Branches      599      947    +348     
=========================================
- Hits       214366   212417   -1949     
+ Misses         85       84      -1     

see 6 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team April 29, 2024 07:25
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Apr 29, 2024
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinions about this since we already use the ESLint rule. Guess an extra layer of "security" won't hurt.

@ST-DDT ST-DDT enabled auto-merge (squash) April 30, 2024 06:19
@ST-DDT ST-DDT merged commit d23cd68 into next Apr 30, 2024
18 checks passed
@Shinigami92 Shinigami92 deleted the chore-enable-verbatimModuleSyntax branch April 30, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants