-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: link to the latest release of the current version #2856
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2856 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2975 2973 -2
Lines 214451 212501 -1950
Branches 952 601 -351
==========================================
- Hits 214378 212415 -1963
- Misses 73 86 +13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice 🚀
As general feedback: If providing screenshots, adding a "before" and "after" image is generally a good idea. If you don't want to do this, at least explain what this image shows that is different from the current behavior. I had difficulties understanding what this PR changed even with the provided title, description, and pictures. In fact, the images made it more confusing for me when I started looking at it. |
Thanks, I try to keep it in mind. |
Fixes #2850 (part2)
This change can be tested by:
v9
next
other