docs(website): show same sidebar on all pages #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
c: docs
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2855 +/- ##
=======================================
Coverage 99.95% 99.96%
=======================================
Files 2973 2973
Lines 212501 212501
Branches 947 949 +2
=======================================
+ Hits 212415 212417 +2
+ Misses 86 84 -2 |
ST-DDT
approved these changes
Apr 28, 2024
matthewmayer
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Definite improvement
Could the sidebar also be added to /api e.g. https://deploy-preview-2855.fakerjs.dev/api/
(or in a seperate PR)
I was also looking into that. I'll add a follow-up PR for that, so we can discuss the necessity of it in there 👍 |
Shinigami92
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request implements an enhancement to the sidebar navigation on our documentation site. The update introduces a streamlined structure for sidebar items, enhancing both user experience and maintenance. Key modifications include the introduction of expandable main sections within the sidebar, providing users with the flexibility to collapse sections that are not immediately relevant. By default, the section corresponding to the current page will be expanded, ensuring a focused and intuitive navigation experience.
Additional Info
This fixes #2852.