-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add donate links #2806
docs: add donate links #2806
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2806 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 2964 2964
Lines 212544 212544
Branches 600 946 +346
==========================================
- Hits 212451 212450 -1
- Misses 93 94 +1 |
I'm not a huge fan of the donation link in the navigation. It is not distinguished enough from other "normal" navigation items, IMO. I would be much more in favor of this if the link would not be located in between other items of the main navigation. For example, putting it at the end or to the social media icons (if that is possible). |
Maybe just start with the footer one only then? |
That would be an option, but I, as a single team member, don't want to be the entire reason for not putting the link there. Opinions of other team members? |
Moving it to the right of the version dropdown is also easy. Moving it next to social links is trickier unless there's some clever hack to do that. |
I don't have a strong onion regarding the placement of the button/link. |
I still like to suggest orientating on https://vitejs.dev/. |
I like this suggestion. Especially the open collective icon. I didn't know that was possible. |
@matthewmayer did you copy the css from the vite website? I'd probably write some styles differently, but it works right now. |
yes, i copy pasted from the buttons at the top |
Add donation links to OC as discussed on Discord, two options
(maybe don't need both, see which you prefer and comment on wording)