Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(commerce)!: remove v8 deprecated commerce method #2752

Merged
merged 3 commits into from
Mar 15, 2024
Merged

refactor(commerce)!: remove v8 deprecated commerce method #2752

merged 3 commits into from
Mar 15, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: commerce Something is referring to the commerce module labels Mar 15, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Mar 15, 2024
@Shinigami92 Shinigami92 self-assigned this Mar 15, 2024
@Shinigami92 Shinigami92 marked this pull request as ready for review March 15, 2024 08:00
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 15, 2024 08:00
@Shinigami92 Shinigami92 requested a review from a team March 15, 2024 08:00
@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (776a625) to head (f4bc4f2).

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2752    +/-   ##
========================================
  Coverage   99.56%   99.56%            
========================================
  Files        2979     2979            
  Lines      250372   250229   -143     
  Branches      982      978     -4     
========================================
- Hits       249284   249143   -141     
- Misses       1059     1086    +27     
+ Partials       29        0    -29
Files Coverage Δ
src/modules/commerce/index.ts 98.57% <100.00%> (-0.42%) ⬇️

... and 31 files with indirect coverage changes

@Shinigami92 Shinigami92 enabled auto-merge (squash) March 15, 2024 15:51
@Shinigami92 Shinigami92 merged commit 8c80877 into next Mar 15, 2024
16 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-commerce-method branch March 15, 2024 16:21
@WontonSam WontonSam mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: commerce Something is referring to the commerce module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox