Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(random)!: remove v8 deprecated image methods #2697

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Feb 27, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Feb 27, 2024
@Shinigami92 Shinigami92 self-assigned this Feb 27, 2024
@Shinigami92 Shinigami92 requested a review from a team February 27, 2024 19:48
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 27, 2024 19:48
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (5125d6c) to head (3d28677).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2697      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2846     2846              
  Lines      249917   249416     -501     
  Branches     1058      678     -380     
==========================================
- Hits       248855   248354     -501     
- Misses       1033     1062      +29     
+ Partials       29        0      -29     
Files Coverage Δ
src/modules/image/index.ts 100.00% <ø> (ø)

... and 31 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team February 27, 2024 20:06
@ST-DDT ST-DDT merged commit e99fba9 into next Feb 29, 2024
16 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-image-methods branch February 29, 2024 10:10
@ST-DDT ST-DDT added the breaking change Cannot be merged when next version is not a major release label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants