Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix unsupported nested css #2696

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

Shinigami92
Copy link
Member

Before this fix:

 building client + server bundles...warnings when minifying css:
 [WARNING] Transforming this CSS nesting syntax is not supported in the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari14") [unsupported-css-nesting]

    <stdin>:4875:8:
      4875    .dark & {         ^

  The nesting transform for this case must generate an ":is(...)" but the configured target environment does not support the ":is" pseudo-class.

@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Feb 27, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Feb 27, 2024
@Shinigami92 Shinigami92 self-assigned this Feb 27, 2024
@Shinigami92 Shinigami92 requested a review from a team February 27, 2024 19:37
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 27, 2024 19:37
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (4ab0731) to head (f59ff15).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2696   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files        2846     2846           
  Lines      249917   249917           
  Branches     1056     1063    +7     
=======================================
+ Hits       248851   248859    +8     
- Misses       1037     1058   +21     
+ Partials       29        0   -29     

see 31 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team February 27, 2024 20:18
@ST-DDT ST-DDT merged commit 5125d6c into next Feb 28, 2024
16 checks passed
@ST-DDT ST-DDT deleted the docs-fix-unsupported-nested-css branch February 28, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants