-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix missing or invalid jsdocs #2630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
labels
Jan 28, 2024
Shinigami92
requested changes
Jan 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2630 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 2807 2807
Lines 250452 250481 +29
Branches 1150 1148 -2
==========================================
+ Hits 249388 249408 +20
- Misses 1036 1045 +9
Partials 28 28
|
Co-authored-by: Shinigami <[email protected]>
Shinigami92
approved these changes
Jan 29, 2024
xDivisionByZerox
approved these changes
Feb 1, 2024
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During #2628 I found some issues with the existing jsdocs. This PR fixes them.
We should probably include them in a v8.x bugfix release to have a clean end to v8.