refactor(helper): deprecate replaceSymbolWithNumber #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
p: 1-normal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2557 +/- ##
==========================================
- Coverage 99.57% 99.56% -0.01%
==========================================
Files 2805 2805
Lines 250126 250166 +40
Branches 1103 1100 -3
==========================================
+ Hits 249065 249082 +17
- Misses 1033 1056 +23
Partials 28 28
|
ST-DDT
reviewed
Nov 21, 2023
Co-authored-by: ST-DDT <[email protected]>
ST-DDT
previously approved these changes
Nov 25, 2023
ST-DDT
reviewed
Nov 25, 2023
Co-authored-by: ST-DDT <[email protected]>
ST-DDT
approved these changes
Nov 25, 2023
xDivisionByZerox
approved these changes
Nov 25, 2023
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1994
Changes done:
deprecated replaceSymbolWithNumber
created a new legacy method legacyReplaceSymbolWithNumber
methods using replaceSymbolWithNumber now use the legacy method instead
no update on unit tests required