Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(string): remove arbitrary limit from sample #2497

Merged
merged 9 commits into from
Nov 7, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 22, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: string Something is referring to the string module labels Oct 22, 2023
@ST-DDT ST-DDT added this to the v8.x milestone Oct 22, 2023
@ST-DDT ST-DDT requested review from a team October 22, 2023 15:34
@ST-DDT ST-DDT self-assigned this Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #2497 (85e4f1f) into next (6df70bc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2497      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2787     2787              
  Lines      249378   249373       -5     
  Branches     1084     1077       -7     
==========================================
- Hits       248328   248303      -25     
- Misses       1022     1042      +20     
  Partials       28       28              
Files Coverage Δ
src/modules/string/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@xDivisionByZerox
Copy link
Member

Should this be considered a breaking change? 🤔

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 22, 2023

Should this be considered a breaking change? 🤔

It lifts a restriction and doesn't add a new one, but I don't care either way.

@ST-DDT ST-DDT enabled auto-merge (squash) November 4, 2023 09:35
@ST-DDT ST-DDT merged commit 6f977f6 into next Nov 7, 2023
20 checks passed
@ST-DDT ST-DDT deleted the refactor/string/sample-limit branch November 7, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: string Something is referring to the string module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants