-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(string): remove arbitrary limit from sample #2497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
p: 1-normal
Nothing urgent
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: string
Something is referring to the string module
labels
Oct 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2497 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 2787 2787
Lines 249378 249373 -5
Branches 1084 1077 -7
==========================================
- Hits 248328 248303 -25
- Misses 1022 1042 +20
Partials 28 28
|
Closed
10 tasks
Should this be considered a breaking change? 🤔 |
It lifts a restriction and doesn't add a new one, but I don't care either way. |
import-brain
approved these changes
Oct 28, 2023
xDivisionByZerox
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: string
Something is referring to the string module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2374