refactor(image)!: randomize defaults

[olrtg]

Removes hard-coded defaults and randomizes them. Did this to all methods in the image module but didn't touch the deprecated ones.

Fixes #2314.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50897d9) 99.55% compared to head (00e36ce) 99.55%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2472   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files        2820     2820           
  Lines      251738   251751   +13     
  Branches     1165     1167    +2     
=======================================
+ Hits       250607   250634   +27     
+ Misses       1102     1088   -14     
  Partials       29       29           

Files	Coverage Δ
src/modules/image/index.ts	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

[olrtg]

Done with the comments! Lunch time for me so please let me know if there's anything left to do on my side so I can work on that later. 🤘🏽

[ST-DDT]

Looks good to me. Please note that it still wont be merged because it is schedulled for v9.

[olrtg]

Thank you so much! a pleasure working with you 🤘🏽

[suyashgulati]

Looks good!

[matthewmayer]

While preparing some draft documentation for the breaking change, i found a problem, you can't prevent grey/blurred images when using faker.image.url()

faker.image.url() picks from faker.image.urlLoremFlickr() and faker.image.urlPicsumPhotos() at random. But faker.image.urlPicsumPhotos() now randomly adds blur and grayscale parameters. If you don't want that you can turn it off using for example

faker.image.urlPicsumPhotos({width:640, height:480, blur:0, grayscale:false})

But faker.image.url doesn't support the blur and grayscale parameters, so

faker.image.url({width:640, height:480, blur:0, grayscale:false}) still gives you blurry or greyscale pics on the 50% of picsum photos.

Perhaps blur:0 and grayscale:false should be passed to urlPicsumPhotos() when called by url()

[olrtg]

@matthewmayer From what I saw in the test snapshots in the latest commit, that should do the trick, but I don't really know how to test this easily or how you test this (will be good to know if you don't mind sharing it).

Let me know if there's something else to fix on my end.

[matthewmayer]

Per #2521 we want to prepare documentation for breaking changes in advance. Please insert this draft content at docs/guide/upgrading_v9/2472.md which will be inserted into the v9 migration guide once this is merged.

### Images now have random width, height and other options by default

`faker.image.url()` now returns an image url with a random width and height by default. To obtain the previous behavior, pass `{width: 640, height: 480}`.

`faker.image.urlLoremFlickr()` now returns an image url with a random width and height by default. To obtain the previous behavior, pass `{width: 640, height: 480}`.

`faker.image.urlPicsumPhotos()` now returns an image url with a random width and height by default, additionally images may be converted to grayscale and blurred at random. To obtain the previous behavior, pass `{width: 640, height: 480, blur: 0, grayscale: false}`

`faker.image.dataUri()` now returns an image url with a random width and height by default, additionally the type of the image is now random. To obtain the previous behavior, pass `{width: 640, height: 480, type: 'svg-uri'}`.

[olrtg]

@matthewmayer done!

[ST-DDT]

Ready for review.