-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(unicorn): no-zero-fractions #2453
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2453 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 2823 2823
Lines 255520 255520
Branches 1105 1105
=======================================
+ Hits 254474 254481 +7
+ Misses 1018 1011 -7
Partials 28 28 |
I don't personally like this rule even if 1.0 and 1 mean the same thing in JS 1.0 hints that you are dealing with floating point numbers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team Decision
No, we don't want this because the zero fractions point to decimal values, even if it doesn't have a runtime impact.
1eea3fd
to
3360a31
Compare
Ref: #2439
Permanently disabled the
unicorn/no-zero-fractions
lint rule.