Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: enable strictNullChecks in tsconfig #2435

Merged
merged 47 commits into from
Nov 14, 2023
Merged

infra: enable strictNullChecks in tsconfig #2435

merged 47 commits into from
Nov 14, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 5, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 5, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 5, 2023
@ST-DDT ST-DDT requested review from a team October 5, 2023 21:44
@ST-DDT ST-DDT self-assigned this Oct 5, 2023
@ST-DDT ST-DDT mentioned this pull request Oct 5, 2023
Closed
ST-DDT
ST-DDT commented Oct 5, 2023
View reviewed changes
docs/.vitepress/versions.ts Show resolved Hide resolved
src/modules/date/index.ts Show resolved Hide resolved
src/modules/person/index.ts Outdated Show resolved Hide resolved
src/modules/finance/index.ts Outdated Show resolved Hide resolved
test/modules/finance_iban.spec.ts Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #2435 (84df921) into next (36fc517) will decrease coverage by 0.01%.
The diff coverage is 90.05%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2435      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      249971   250064      +93     
  Branches     1081     1098      +17     
==========================================
+ Hits       248906   248994      +88     
- Misses       1037     1042       +5     
  Partials       28       28
Files Coverage Δ
src/locale-proxy.ts 100.00% <100.00%> (ø)
src/modules/airline/index.ts 100.00% <100.00%> (ø)
src/modules/color/index.ts 99.79% <100.00%> (+<0.01%) ⬆️
src/modules/date/index.ts 99.92% <100.00%> (-0.08%) ⬇️
src/modules/finance/index.ts 100.00% <100.00%> (ø)
src/modules/helpers/index.ts 98.98% <100.00%> (ø)
src/modules/helpers/unique.ts 98.68% <100.00%> (ø)
src/modules/internet/index.ts 100.00% <100.00%> (ø)
src/modules/random/index.ts 100.00% <100.00%> (ø)
src/definitions/definitions.ts 0.00% <0.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT marked this pull request as ready for review October 5, 2023 22:07
@ST-DDT ST-DDT requested a review from a team October 5, 2023 22:07
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 5, 2023

Ready for review.

xDivisionByZerox
xDivisionByZerox requested changes Oct 5, 2023
View reviewed changes
cypress/e2e/api.cy.ts Outdated Show resolved Hide resolved
src/locales/ar/date/weekday.ts Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
docs/.vitepress/versions.ts Outdated Show resolved Hide resolved
scripts/apidoc/fakerClass.ts Outdated Show resolved Hide resolved
src/modules/date/index.ts Outdated Show resolved Hide resolved
src/modules/date/index.ts Outdated Show resolved Hide resolved
src/modules/finance/index.ts Outdated Show resolved Hide resolved
test/faker.spec.ts Outdated Show resolved Hide resolved
test/vitest-extensions.ts Outdated Show resolved Hide resolved
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 6, 2023

Ready for review again. 😉

@ST-DDT ST-DDT requested review from xDivisionByZerox and a team October 6, 2023 23:00
@ST-DDT ST-DDT enabled auto-merge (squash) November 6, 2023 08:21
@ST-DDT ST-DDT disabled auto-merge November 6, 2023 08:32
ST-DDT
ST-DDT commented Nov 6, 2023
View reviewed changes
src/modules/date/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team November 6, 2023 21:01
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team November 10, 2023 17:07
@ST-DDT ST-DDT mentioned this pull request Nov 13, 2023
Merged
@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 14, 2023

Team Decision

This is largely unchanged since creation and has been approved for more than a week (if you ignore the minor merge conflicts).

@ST-DDT ST-DDT enabled auto-merge (squash) November 14, 2023 16:05
@ST-DDT ST-DDT merged commit 7e3c92e into next Nov 14, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/tsconfig/enable-strictNullChecks branch November 14, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
2 participants
@ST-DDT @xDivisionByZerox