chore: add eslint unicorn #2417

Shinigami92 · 2023-09-23T17:16:36Z

This PR will make @fisker really happy ❤️

ST-DDT · 2023-09-23T17:39:03Z

.eslintrc.js

  ],
  parser: '@typescript-eslint/parser',
  parserOptions: {
    project: ['./tsconfig.json'],
    sourceType: 'module',
    warnOnUnsupportedTypeScriptVersion: false,
  },
-  plugins: ['@typescript-eslint', 'prettier', 'deprecation'],
+  plugins: ['@typescript-eslint', 'prettier', 'deprecation', 'unicorn'],


This is optional/already covered by the extends config.

ST-DDT · 2023-09-23T17:46:55Z

.eslintrc.js

+      'error',
+      {
+        allowList: {
+          args: true,


Why args but not arg?

test/modules/helpers.spec.ts

ST-DDT · 2023-09-23T17:53:41Z

test/modules/helpers.spec.ts

@@ -461,7 +461,7 @@ describe('helpers', () => {
          const input = Array.from({ length: 2 }, (_, i) => i);
          const occurrences = Array.from({ length: 2 }, () => 0);

-          for (let i = 0; i < 1000; i++) {
+          for (let index = 0; index < 1000; index++) {


This isnt the index it is a counter.

test/modules/helpers.spec.ts

ST-DDT · 2023-09-23T17:58:05Z

.eslintrc.js

+        allowList: {
+          args: true,
+          fn: true,
+          obj: true,


Why obj, but not str/num?

ST-DDT · 2023-09-23T18:04:09Z

test/modules/color.spec.ts

@@ -44,8 +44,8 @@ describe('color', () => {

      describe(`cssSupportedFunction()`, () => {
        it('should return random css supported color function from css functions array', () => {
-          const func = faker.color.cssSupportedFunction();
-          expect(Object.values(CssFunction)).toContain(func);
+          const supportedFunction = faker.color.cssSupportedFunction();


Maybe name it actual same as in our other tests?

ST-DDT · 2023-09-23T18:07:46Z

test/modules/date.spec.ts

@@ -358,11 +358,11 @@ describe('date', () => {
            expect(dates.length).lessThanOrEqual(5);

            expect(dates[0]).greaterThan(from);
-            for (let i = 1; i < dates.length; i++) {
-              expect(dates[i]).greaterThan(dates[i - 1]);
+            for (let index = 1; index < dates.length; index++) {


This seems unnessarily verbose.

ST-DDT · 2023-09-23T18:11:51Z

Note to self. Check all the regexes again.

Shinigami92 · 2023-09-23T18:12:06Z

@ST-DDT I highly suggest you start reviewing this when I'm actually done with it
There are more then 800 errors I need to manually go through
I'm already sitting on this more than an hour and I make a break now, playing Overwatch

codecov · 2023-09-23T18:14:50Z

Codecov Report

Merging #2417 (456698f) into next (74eeccc) will decrease coverage by 0.01%.
The diff coverage is 97.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2417      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files        2802     2802              
  Lines      252486   252544      +58     
  Branches     1103     1101       -2     
==========================================
+ Hits       251499   251553      +54     
- Misses        960      964       +4     
  Partials       27       27

Files Changed	Coverage Δ
src/definitions/science.ts	`0.00% <0.00%> (ø)`
src/definitions/system.ts	`0.00% <0.00%> (ø)`
src/locales/base/system/directory_paths.ts	`100.00% <ø> (ø)`
src/locales/base/system/mime_types.ts	`100.00% <ø> (ø)`
src/locales/en/science/chemical_element.ts	`100.00% <ø> (ø)`
src/locales/eo/science/chemical_element.ts	`100.00% <ø> (ø)`
src/locales/nb_NO/science/chemical_element.ts	`100.00% <ø> (ø)`
src/locales/pl/science/chemical_element.ts	`100.00% <ø> (ø)`
src/modules/internet/user-agent.ts	`91.17% <87.50%> (-0.25%)`	⬇️
src/modules/person/index.ts	`98.01% <90.00%> (+<0.01%)`	⬆️
... and 38 more

ST-DDT · 2023-09-23T18:14:16Z

test/modules/helpers.spec.ts

            const occurrences = Array.from({ length: 10 }, () => 0);

-            for (let i = 0; i < 1000; i++) {
+            for (let index = 0; index < 1000; index++) {


This isnt an index.

ST-DDT · 2023-09-23T18:15:46Z

test/modules/image.spec.ts

@@ -485,7 +485,7 @@ describe('image', () => {

      expect(imageUrl).toBeTypeOf('string');
      expect(imageUrl).toMatch(
-        /^https\:\/\/via\.placeholder\.com\/\d+x\d+\/[0-9a-fA-F]{6}\/[0-9a-fA-F]{6}\.[a-z]{3,4}\?text=.+$/
+        /^ht{2}ps:\/{2}via\.placeholder\.com\/\d+x\d+(?:\/[\dA-Fa-f]{6}){2}\.[a-z]{3,4}\?text=.+$/


No. ht{2}ps:\/{2} 🙅

ST-DDT · 2023-09-23T18:16:57Z

test/modules/internet.spec.ts

@@ -297,7 +297,7 @@ describe('internet', () => {
          const [prefix, suffix] = email.split('@');

          expect(prefix).toMatch(
-            /^Mike((\d{1,2})|([.!#$%&'*+-/=?^_`{|}~]Smith\d{1,2})|([.!#$%&'*+-/=?^_`{|}~]Smith))/
+            /^Mike((\d{1,2})|([!#$%&'*+-/=?^_`{|}~]Smith\d{1,2})|([!#$%&'*+-/=?^_`{|}~]Smith))/


Note to self: Where did the dot go?

test/modules/lorem.spec.ts

ST-DDT · 2023-09-23T18:25:43Z

test/support/seeded-runs.ts

@@ -142,7 +142,7 @@ class TestGenerator<
    repetitions: number = 1
  ): void {
    this.setup();
-    for (let i = 0; i < repetitions; i++) {
+    for (let index = 0; index < repetitions; index++) {


This isnt an index.

ST-DDT · 2023-09-23T18:30:14Z

@ST-DDT I highly suggest you start reviewing this when I'm actually done with it There are more then 800 errors I need to manually go through I'm already sitting on this more than an hour and I make a break now, playing Overwatch

I'm not sure I want to review 800 changes in one PR.

Correction: The current number of addressed (types of) issues already exceeds what I'm willing to review in a single PR.

ST-DDT

This PR is not reviewable due to size/different kind of changes.

Shinigami92 · 2023-09-23T20:52:42Z

As @ST-DDT already pointed out, I need to split this into several PRs, to reduce the amount of changed files in the same PR.

This PR now reflects the approximate change when everything is merged individually.

While working on this PR, I at least learned some stuff I can reuse to work on the individual PRs.
And maybe this PR gets so much reduces in diff count, that it can then be used to check the rest that is left over.

Shinigami92 · 2023-09-23T20:53:44Z

I switched from on hold to do not merge, because on hold is for that the work is not going forward, which is effectively wrong in this case

ST-DDT · 2023-10-06T23:50:00Z

This has been superseded by #2418 and individual PRs per rule.

Since Shinigami92 is no longer actively working on this. I will close this because of the merge conflicts.
The diff is visible here forever and the branch can be restored if needed as well.

Shinigami92 added c: dependencies Pull requests that adds/updates a dependency c: infra Changes to our infrastructure or project setup labels Sep 23, 2023

Shinigami92 added this to the vAnytime milestone Sep 23, 2023

Shinigami92 self-assigned this Sep 23, 2023

Shinigami92 mentioned this pull request Sep 23, 2023

feat: support custom randomizer #2284

Merged

Shinigami92 changed the title ~~infra: add eslint unicorn~~ chore: add eslint unicorn Sep 23, 2023

Shinigami92 added c: chore PR that doesn't affect the runtime behavior and removed c: infra Changes to our infrastructure or project setup labels Sep 23, 2023

Shinigami92 force-pushed the add-eslint-unicorn branch 4 times, most recently from be40894 to 1c2d022 Compare September 23, 2023 17:56

ST-DDT reviewed Sep 23, 2023

View reviewed changes

Shinigami92 force-pushed the add-eslint-unicorn branch from 1c2d022 to b9fa313 Compare September 23, 2023 18:10

ST-DDT reviewed Sep 23, 2023

View reviewed changes

ST-DDT added s: needs decision Needs team/maintainer decision s: on hold Blocked by something or frozen to avoid conflicts labels Sep 23, 2023

ST-DDT requested changes Sep 23, 2023

View reviewed changes

Shinigami92 force-pushed the add-eslint-unicorn branch 4 times, most recently from 57d0a9e to b27a254 Compare September 23, 2023 20:37

chore: add eslint unicorn

456698f

Shinigami92 force-pushed the add-eslint-unicorn branch from b27a254 to 456698f Compare September 23, 2023 20:49

Shinigami92 added do NOT merge yet Do not merge this PR into the target branch yet and removed s: needs decision Needs team/maintainer decision s: on hold Blocked by something or frozen to avoid conflicts labels Sep 23, 2023

Shinigami92 mentioned this pull request Sep 23, 2023

infra(deps): add eslint unicorn #2418

Merged

ST-DDT added the needs rebase There is a merge conflict label Sep 25, 2023

ST-DDT closed this Oct 6, 2023

ST-DDT deleted the add-eslint-unicorn branch October 6, 2023 23:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add eslint unicorn #2417

chore: add eslint unicorn #2417

Shinigami92 commented Sep 23, 2023

ST-DDT Sep 23, 2023

ST-DDT Sep 23, 2023

ST-DDT Sep 23, 2023

ST-DDT Sep 23, 2023

ST-DDT Sep 23, 2023

ST-DDT Sep 23, 2023

ST-DDT commented Sep 23, 2023

Shinigami92 commented Sep 23, 2023

codecov bot commented Sep 23, 2023 •

edited

Loading

ST-DDT Sep 23, 2023

ST-DDT Sep 23, 2023

ST-DDT Sep 23, 2023

ST-DDT Sep 23, 2023

ST-DDT commented Sep 23, 2023 •

edited

Loading

ST-DDT left a comment

Shinigami92 commented Sep 23, 2023

Shinigami92 commented Sep 23, 2023

ST-DDT commented Oct 6, 2023

chore: add eslint unicorn #2417

chore: add eslint unicorn #2417

Conversation

Shinigami92 commented Sep 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ST-DDT commented Sep 23, 2023

Shinigami92 commented Sep 23, 2023

codecov bot commented Sep 23, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ST-DDT commented Sep 23, 2023 • edited Loading

ST-DDT left a comment

Choose a reason for hiding this comment

Shinigami92 commented Sep 23, 2023

Shinigami92 commented Sep 23, 2023

ST-DDT commented Oct 6, 2023

codecov bot commented Sep 23, 2023 •

edited

Loading

ST-DDT commented Sep 23, 2023 •

edited

Loading