-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add minimal da locale, start with location #2324
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2324 +/- ##
==========================================
- Coverage 99.60% 99.59% -0.01%
==========================================
Files 2644 2660 +16
Lines 245613 246345 +732
Branches 1084 1082 -2
==========================================
+ Hits 244640 245357 +717
- Misses 946 961 +15
Partials 27 27
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider making this locale da_DK as Danish is spoken in some other territories with their own ISO codes like Greenland or Faroe Islands?
No, because these other territories probably share a lot of the names/values with Denmark and we shouldn't duplicate them. |
I'm not sure when we do lang vs lang_COUNTRY though. Eg ka_GE and sr_RS were added recently |
As suggested in #2321, add new language in smaller chunks.