-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): Fully Improve zh_TW #2320
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2320 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 2660 2649 -11
Lines 246345 245706 -639
Branches 1086 1086
==========================================
- Hits 245375 244729 -646
- Misses 943 950 +7
Partials 27 27
|
Please run |
@Shinigami92 @xDivisionByZerox @import-brain Could you review this for me? Thanks a lot! |
It is quite normal that PRs in the Faker project can take weeks to get reviewed and merged even if they are 100% fine. You don't need to do anything, the maintainers will notify you if any changes are needed. |
I wouldnt limit this to Faker or OpenSource specifically. It is just a mater of available time and priorities. |
Thanks for your contribution. ❤️ |
Works
Fix according to ISO codes