Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): support color and date for zh_CN #2223

Merged
merged 5 commits into from
Jun 25, 2023
Merged

feat(locale): support color and date for zh_CN #2223

merged 5 commits into from
Jun 25, 2023

Conversation

Flower-F
Copy link
Contributor

support color and date for zh_CN

@Flower-F Flower-F requested a review from a team as a code owner June 23, 2023 14:01
ST-DDT
ST-DDT previously approved these changes Jun 23, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from a team June 23, 2023 17:21
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: color Something is referring to the color module m: date Something is referring to the date module labels Jun 23, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Jun 23, 2023

Looks good to me. Thanks for your contribution ❤️ !

@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

Merging #2223 (5538039) into next (bbda1d7) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2223      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.02%     
==========================================
  Files        2632     2637       +5     
  Lines      245581   245674      +93     
  Branches     1156     1153       -3     
==========================================
+ Hits       244616   244681      +65     
- Misses        938      966      +28     
  Partials       27       27
Impacted Files Coverage Δ
src/locales/zh_CN/color/human.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/color/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/date/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/date/month.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

ejcheng
ejcheng previously approved these changes Jun 23, 2023
View reviewed changes
@ejcheng
Copy link
Member

ejcheng commented Jun 23, 2023

All entries are valid, lgtm

@Flower-F Flower-F dismissed stale reviews from ejcheng and ST-DDT via ee4125f June 24, 2023 05:16
matthewmayer
matthewmayer previously approved these changes Jun 24, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from a team and matthewmayer June 24, 2023 14:13
@ST-DDT ST-DDT merged commit 6736cbf into faker-js:next Jun 25, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Jun 25, 2023

Once again: Thanks for your contribution ❤️

@Flower-F
Copy link
Contributor Author

Once again: Thanks for your contribution ❤️
❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@ejcheng ejcheng ejcheng approved these changes

Assignees

@Flower-F Flower-F

Labels
c: locale Permutes locale definitions m: color Something is referring to the color module m: date Something is referring to the date module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@Flower-F @ST-DDT @ejcheng @matthewmayer