-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: replace deprecated datatype.uuid() with string.uuid() #2214
Conversation
https://github.com/faker-js/faker/blob/next/docs/guide/usage.md also has a few references to the old method. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2214 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 2607 2607
Lines 245002 245002
Branches 1152 1155 +3
=======================================
+ Hits 244017 244031 +14
+ Misses 958 944 -14
Partials 27 27 |
51d3af1
helpers.unique is only soft deprecated and there isn't a replacement yet, so there is no need to replace it yet. |
Do I submit another PR? |
Sorry, I don't understand. Why do you want to open another PR exactly? 🤔 |
They Mentioned that there were other changes in another document, I changed them and this is why I am asking. |
Ah gotcha. @ST-DDT changed the PR title so it better reflects all changes done in the PR. Thank you for your contribution ❤️ |
No description provided.