Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add company name to zh_CN #2203

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

ZACHSTRIVES
Copy link
Contributor

Add company name to zh_CN

@ZACHSTRIVES ZACHSTRIVES requested a review from a team as a code owner June 8, 2023 06:04
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: company Something is referring to the company module labels Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #2203 (9d3a722) into next (b9008bf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 9d3a722 differs from pull request most recent head 5932b85. Consider uploading reports for the commit 5932b85 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2203      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2607     2611       +4     
  Lines      245002   245049      +47     
  Branches     1150     1151       +1     
==========================================
+ Hits       244012   244052      +40     
- Misses        963      970       +7     
  Partials       27       27              
Impacted Files Coverage Δ
src/locales/zh_CN/company/category.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/company/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/company/name_pattern.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/company/type.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@matthewmayer
Copy link
Contributor

some sample output:

[
  '上林市烨华保险集团有限公司',
  '山东省博文食品有限责任公司',
  '武都市擎宇燃气无限公司',
  '上林市天宇印刷(集团)有限公司',
  '诸南市凯瑞保险无限公司',
  '宁原市鹤轩建设有限责任公司',
  '宁京市绍齐食品集团有限公司',
  '陕西省伟诚网络科技集团有限公司',
  '贵州省志泽物流有限公司',
  '上海市昊然水产股份有限公司',
  '厦沙市健柏燃气集团有限公司',
  '海安市鹏涛食品有限责任公司',
  '太沙市晓博网络科技股份有限公司',
  '太州市天磊印刷无限责任公司',
  '湖北省子默林业无限责任公司',
  '上码市鹏涛保险股份有限公司',
  '福头市鑫磊物流集团有限公司',
  '南口市明哲运输有限责任公司',
  '内蒙古建辉燃气有限责任公司',
  '厦海市彬保险集团有限公司'
]

and some rough English translations: looks fairly convincing.

[
   'Shanglin Yehua Insurance Group Co., Ltd',
   'Shandong Bowen Food Co., Ltd',
   'Wudu City Qingyu Gas Co., Ltd',
   'Shanglin Tianyu Printing (Group) Co., Ltd',
   'Zhunan City Kerry Insurance Co., Ltd',
   'Ningyuan City Hexuan Construction Co., Ltd',
   'Ningjing Shaoqi Food Group Co., Ltd',
   'Shaanxi Weicheng Network Technology Group Co., Ltd',
   'Guizhou Zhize Logistics Co., Ltd',
   'Shanghai Haoran Aquatic Products Co., Ltd',
   'Xiasha Jianbai Gas Group Co., Ltd',
   'Haian Pengtao Food Co., Ltd',
   'Taisha Xiaobo Network Technology Co., Ltd',
   'Taizhou Tianlei Printing Co., Ltd',
   'Hubei Zimo Forestry Co., Ltd',
   'Shangma City Pengtao Insurance Co., Ltd',
   'Futou Xinlei Logistics Group Co., Ltd',
   'Nankou Mingzhe Transportation Co., Ltd',
   'Inner Mongolia Jianhui Gas Co., Ltd',
   'Xiahai Bin Insurance Group Co., Ltd.'
]

@ST-DDT ST-DDT requested a review from a team June 9, 2023 06:43
@ST-DDT ST-DDT enabled auto-merge (squash) June 16, 2023 19:55
@ST-DDT ST-DDT merged commit c3b540f into faker-js:next Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: company Something is referring to the company module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants