fix(locale): remove continent from ja countries #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KeisukeYamashita <[email protected]>
matthewmayer
approved these changes
Jun 2, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2194 +/- ##
==========================================
- Coverage 99.60% 99.59% -0.01%
==========================================
Files 2607 2607
Lines 245029 245021 -8
Branches 1154 1151 -3
==========================================
- Hits 244049 244030 -19
- Misses 953 964 +11
Partials 27 27
|
import-brain
added
p: 1-normal
import-brain
approved these changes
Jun 4, 2023
|
Translated the removed continents to English to check, lgtm 👍 |
ST-DDT
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, sorry for the bothering 🙏
I noticed that there are many continents in the country list.
I would like to remove it because the dummy data for user profiles in the service, as it generates strange profiles, such as Antarctica as the country of residence.
Thank you in advance.