-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): support street and street address for ja #2193
feat(locale): support street and street address for ja #2193
Conversation
Signed-off-by: KeisukeYamashita <[email protected]>
Sorry, the CI failed. |
Looks like you forgot to run |
Signed-off-by: KeisukeYamashita <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
Thank you very much for your comment, I have ran and push this commit 👉 a83f75a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2193 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 2973 2975 +2
Lines 212592 212600 +8
Branches 949 951 +2
=======================================
+ Hits 212452 212460 +8
- Misses 136 140 +4
+ Partials 4 0 -4
|
Signed-off-by: KeisukeYamashita <[email protected]>
Signed-off-by: KeisukeYamashita <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
Sorry for the long wait. This somehow got lost in the PR backlog. |
Team Decision
|
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for your consideration! |
Fixed (added) Japanese address output.
Previously, English addresses were generated incorrectly, but the format has been changed to the correct address format.
Street address example:
Symbols can now be used in street addresses because street names in Japan sometimes contain numbers, but this has no other destructive effect. Of course, not all country road formats include numbers, but I believe they are used in many countries. I supported it because the use of symbols is completely restricted now.
Thank you in advance.
Disclaimer
I am not a government official or lawyer in charge of Japanese geography. However, in its current state, it is difficult to use it for address dummy data, so a PR was created.