Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(number): update default max value #2176

Merged
merged 4 commits into from
May 25, 2023

Conversation

dephiros
Copy link
Contributor

Address #2175

  • Fix the default max
  • Add a note in the migration guide

- Fix the default max
- Add a note in the migration guide
@dephiros dephiros requested a review from a team May 24, 2023 17:05
@dephiros dephiros requested a review from a team as a code owner May 24, 2023 17:05
@Shinigami92 Shinigami92 linked an issue May 24, 2023 that may be closed by this pull request
10 tasks
@Shinigami92 Shinigami92 added c: bug Something isn't working c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: number Something is referring to the number module labels May 24, 2023
@Shinigami92 Shinigami92 changed the base branch from v8 to next May 24, 2023 17:14
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #2176 (faac3c5) into next (b600547) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2176      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.01%     
==========================================
  Files        2607     2607              
  Lines      244977   244977              
  Branches     1150     1147       -3     
==========================================
- Hits       244000   243990      -10     
- Misses        950      960      +10     
  Partials       27       27              
Impacted Files Coverage Δ
src/modules/number/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@Shinigami92
Copy link
Member

Oh, I switched the target branch from v8 to next, because this is out "main"/default branch
next will get merged into v8 when the release is made

Shinigami92
Shinigami92 previously approved these changes May 24, 2023
Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@ST-DDT ST-DDT merged commit f901e3d into faker-js:next May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: docs Improvements or additions to documentation m: number Something is referring to the number module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Documentation for number.int default max value is not correct
4 participants