Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra!: drop NodeJS v14 and v16 support #2121

Merged
merged 6 commits into from
Feb 9, 2024
Merged

infra!: drop NodeJS v14 and v16 support #2121

merged 6 commits into from
Feb 9, 2024

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented May 3, 2023 •
edited
Loading

Drop support for NodeJS v14 due to it reached EOL 2023-04-30

This is targeted for v9.0 and can be merged now ✅

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent do NOT merge yet Do not merge this PR into the target branch yet c: dependencies Pull requests that adds/updates a dependency breaking change Cannot be merged when next version is not a major release labels May 3, 2023
@Shinigami92 Shinigami92 added this to the v9 - Next major milestone May 3, 2023
@Shinigami92 Shinigami92 self-assigned this May 3, 2023
@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c7f78d) 99.57% compared to head (5caed14) 99.57%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2121      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2807     2807              
  Lines      250525   250525              
  Branches      742     1151     +409     
==========================================
- Hits       249464   249451      -13     
- Misses       1033     1046      +13     
  Partials       28       28

see 1 file with indirect coverage changes

@Shinigami92 Shinigami92 mentioned this pull request May 3, 2023
Merged
Shinigami92
Shinigami92 commented May 5, 2023
View reviewed changes
scripts/bundle.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 force-pushed the drop-node-v14-support branch 2 times, most recently from 861cdc4 to 5edf310 Compare May 10, 2023 14:17
@Shinigami92 Shinigami92 changed the title infra!: drop NodeJS v14 support infra!: drop NodeJS v14 and v16 support Sep 17, 2023
Shinigami92
Shinigami92 commented Sep 17, 2023
View reviewed changes
scripts/bundle.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT modified the milestones: v9.x, v9.0 Oct 3, 2023
@xDivisionByZerox xDivisionByZerox mentioned this pull request Dec 28, 2023
Merged
@matthewmayer
Copy link
Contributor

Per #2521 suggest adding the following to docs/guide/upgrading_v9/2121.md:

### Node 14 and 16 No Longer Supported

Support for Node.js versions 14 and 16 has been discontinued as these versions have reached their [end-of-life](https://github.com/nodejs/Release). Faker.js 9.0 requires a minimum of Node.js version 18.

@Shinigami92 Shinigami92 force-pushed the drop-node-v14-support branch 2 times, most recently from c2f764c to 5e6d4a4 Compare January 19, 2024 08:38
@Shinigami92
Copy link
Member Author

Per #2521 suggest adding the following to docs/guide/upgrading_v9/2121.md:

### Node 14 and 16 No Longer Supported

Support for Node.js versions 14 and 16 has been discontinued as these versions have reached their [end-of-life](https://github.com/nodejs/Release). Faker.js 9.0 requires a minimum of Node.js version 18.

Added 👍

@ST-DDT
Copy link
Member

ST-DDT commented Feb 8, 2024

@Shinigami92 Could you please fix the merge conflicts here?

@ST-DDT ST-DDT added needs rebase There is a merge conflict and removed do NOT merge yet Do not merge this PR into the target branch yet labels Feb 8, 2024
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Feb 9, 2024
@Shinigami92 Shinigami92 marked this pull request as ready for review February 9, 2024 07:23
@Shinigami92 Shinigami92 requested a review from a team February 9, 2024 07:23
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 9, 2024 07:23
@ST-DDT ST-DDT requested review from a team February 9, 2024 08:04
@Shinigami92 Shinigami92 merged commit 1e0df8b into next Feb 9, 2024
19 checks passed
@Shinigami92 Shinigami92 deleted the drop-node-v14-support branch February 9, 2024 08:18
@WontonSam WontonSam mentioned this pull request Sep 29, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: dependencies Pull requests that adds/updates a dependency c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: In Progress
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox