Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): add additional metadata properties #2025

Merged
merged 10 commits into from
Apr 22, 2023
Merged

feat(locale): add additional metadata properties #2025

merged 10 commits into from
Apr 22, 2023

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Apr 5, 2023 •
edited
Loading

fix #2012

  • Tried to make locale titles more consistent, so if a country is specified it's always in parentheses. Also favour Slovak and Nepali over Slovakian and Nepalese.
  • only put minimal data for base locale
  • this probably needs more tests, but not sure exactly what best to test

@matthewmayer matthewmayer requested a review from a team April 5, 2023 08:54
@matthewmayer matthewmayer requested a review from a team as a code owner April 5, 2023 08:54
@matthewmayer
Copy link
Contributor Author

i might need some assistance with the "Make MetadataDefinitions optional and Partial" part, wasn't sure how to do that.

@codecov
Copy link

codecov bot commented Apr 5, 2023 •
edited
Loading

Codecov Report

Merging #2025 (d4123b0) into next (ed19bef) will decrease coverage by 0.03%.
The diff coverage is 89.16%.

❗ Current head d4123b0 differs from pull request most recent head 1cfdee2. Consider uploading reports for the commit 1cfdee2 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2025      +/-   ##
==========================================
- Coverage   99.61%   99.59%   -0.03%     
==========================================
  Files        2538     2563      +25     
  Lines      242253   243670    +1417     
  Branches     1299     1278      -21     
==========================================
+ Hits       241319   242672    +1353     
- Misses        907      971      +64     
  Partials       27       27
Impacted Files Coverage Δ
src/definitions/definitions.ts 0.00% <0.00%> (ø)
src/definitions/metadata.ts 0.00% <0.00%> (ø)
src/locales/af_ZA/metadata.ts 100.00% <100.00%> (ø)
src/locales/ar/metadata.ts 100.00% <100.00%> (ø)
src/locales/az/metadata.ts 100.00% <100.00%> (ø)
src/locales/base/metadata.ts 100.00% <100.00%> (ø)
src/locales/cs_CZ/metadata.ts 100.00% <100.00%> (ø)
src/locales/de/metadata.ts 100.00% <100.00%> (ø)
src/locales/de_AT/metadata.ts 100.00% <100.00%> (ø)
src/locales/de_CH/metadata.ts 100.00% <100.00%> (ø)
... and 55 more

... and 361 files with indirect coverage changes

@matthewmayer matthewmayer self-assigned this Apr 5, 2023
@matthewmayer matthewmayer added c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent labels Apr 5, 2023
@ST-DDT ST-DDT mentioned this pull request Apr 5, 2023
Merged
ST-DDT
ST-DDT reviewed Apr 5, 2023
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the suggested metadata definition type changes as requested: matthewmayer#1

src/definitions/metadata.ts Show resolved Hide resolved
src/definitions/metadata.ts Outdated Show resolved Hide resolved
@matthewmayer
Merge pull request #1 from faker-js/pr/matthewmayer/2025-suggestions/…
a3af163 
…st-ddt

feat(locale): add additional metadata properties
@matthewmayer
Copy link
Contributor Author

i might need some assistance with the "Make MetadataDefinitions optional and Partial" part, wasn't sure how to do that.

thanks for the help on this!

ST-DDT
ST-DDT previously approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filling in these metadata. The PR looks good to me.

I will have another look at the endonyms tomorrow just to be sure nothing slipped my checks.

@ST-DDT ST-DDT requested review from a team April 5, 2023 23:27
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Apr 5, 2023
xDivisionByZerox
xDivisionByZerox reviewed Apr 7, 2023
View reviewed changes
src/definitions/metadata.ts Outdated Show resolved Hide resolved
src/definitions/metadata.ts Show resolved Hide resolved
src/locales/sr_RS_latin/metadata.ts Show resolved Hide resolved
test/locale-imports.spec.ts Show resolved Hide resolved
test/locale-imports.spec.ts Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Apr 8, 2023
View reviewed changes
@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Apr 8, 2023
Shinigami92
Shinigami92 reviewed Apr 9, 2023
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all in all looks good to me
still just some questions and suggestions

src/definitions/definitions.ts Show resolved Hide resolved
src/definitions/metadata.ts Show resolved Hide resolved
src/definitions/metadata.ts Outdated Show resolved Hide resolved
test/locale-imports.spec.ts Outdated Show resolved Hide resolved
@matthewmayer matthewmayer mentioned this pull request Apr 9, 2023
Merged
@ST-DDT ST-DDT requested review from Shinigami92 and a team April 9, 2023 17:01
@matthewmayer matthewmayer removed the s: needs decision Needs team/maintainer decision label Apr 11, 2023
@ST-DDT ST-DDT requested a review from a team April 22, 2023 14:18
@ST-DDT ST-DDT enabled auto-merge (squash) April 22, 2023 16:26
@ST-DDT ST-DDT merged commit a49aa0d into faker-js:next Apr 22, 2023
@xDivisionByZerox xDivisionByZerox mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

More metadata for each locale
4 participants
@matthewmayer @ST-DDT @Shinigami92 @xDivisionByZerox