-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale)!: move title to metadata #1978
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1978 +/- ##
========================================
Coverage 99.62% 99.62%
========================================
Files 2464 2526 +62
Lines 240224 240708 +484
Branches 1277 1277
========================================
+ Hits 239328 239815 +487
+ Misses 873 869 -4
- Partials 23 24 +1
|
i would like to see more metadata added, for example:
|
Yes 🙌 Edit: And this is also why I suggested to not move primitive data into own files |
agreed, if there are ~7 metadata items like this it should be in one file total |
I did it like this to avoid having to add special handling for any of these, but I will add that back. |
35d1306
Removes the special handling of
faker.definitions.title
by moving it tofaker.definitions.metadata.title
.As this makes it way easier to (type) safely implement #893.