Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(color): improve rgb examples #1970

Merged
merged 5 commits into from
Mar 27, 2023
Merged

docs(color): improve rgb examples #1970

merged 5 commits into from
Mar 27, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #1967

@codecov
Copy link

codecov bot commented Mar 24, 2023 •
edited
Loading

Codecov Report

Merging #1970 (18c5e55) into next (87a5ba9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1970      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2450     2450              
  Lines      239449   239453       +4     
  Branches     1229     1230       +1     
==========================================
+ Hits       238569   238571       +2     
- Misses        858      860       +2     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/color/index.ts 99.79% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

@matthewmayer matthewmayer marked this pull request as ready for review March 24, 2023 02:31
@matthewmayer matthewmayer requested a review from a team as a code owner March 24, 2023 02:31
@matthewmayer matthewmayer added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: color Something is referring to the color module labels Mar 24, 2023
Shinigami92
Shinigami92 reviewed Mar 24, 2023
View reviewed changes
src/modules/color/index.ts Outdated Show resolved Hide resolved
src/modules/color/index.ts Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Mar 24, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from a team March 24, 2023 09:05
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 24, 2023
@ST-DDT ST-DDT changed the title docs(color): add more includeAlpha examples to color.rgb, standardize examples docs(color): improve rgb examples Mar 27, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) March 27, 2023 11:46
@ST-DDT ST-DDT merged commit 2a4f137 into faker-js:next Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: docs Improvements or additions to documentation m: color Something is referring to the color module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Add includeAlpha to color examples
3 participants
@matthewmayer @ST-DDT @Shinigami92