Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(string): rename special to symbol #1789

Merged
merged 6 commits into from
Jan 29, 2023
Merged

refactor(string): rename special to symbol #1789

merged 6 commits into from
Jan 29, 2023

Conversation

xDivisionByZerox
Copy link
Member

Resolves #1711.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: string Something is referring to the string module labels Jan 29, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team January 29, 2023 02:38
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner January 29, 2023 02:38
@xDivisionByZerox xDivisionByZerox self-assigned this Jan 29, 2023
@codecov
Copy link

codecov bot commented Jan 29, 2023 •
edited
Loading

Codecov Report

Merging #1789 (d9cc0b6) into next (cec7877) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1789   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files        2340     2340           
  Lines      242619   242622    +3     
  Branches     1113     1113           
=======================================
+ Hits       241783   241786    +3     
  Misses        815      815           
  Partials       21       21
Impacted Files Coverage Δ
src/modules/string/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT enabled auto-merge (squash) January 29, 2023 16:22
@ST-DDT ST-DDT merged commit 7bc4a09 into next Jan 29, 2023
@ST-DDT ST-DDT deleted the refactor/string/rename-special-to-symbol branch January 29, 2023 16:33
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
@xDivisionByZerox @matthewmayer
refactor(string): rename special to symbol (faker-js#1789)
5fe7959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@pkuczynski pkuczynski pkuczynski approved these changes

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Generate random symbol (eg: ! _ #)
5 participants
@xDivisionByZerox @pkuczynski @ST-DDT @Shinigami92 @import-brain