Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(helpers): widen arrayElements distribution #1786

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

Shinigami92
Copy link
Member

while working on

we run into arrayElements expectation failures
this PR just widens the distribution for now as for small numbers the error is much more present as for larger iterations

@Shinigami92 Shinigami92 requested a review from a team as a code owner January 27, 2023 15:48
@Shinigami92 Shinigami92 self-assigned this Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #1786 (44490c5) into next (86ae8b9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1786   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2340     2340           
  Lines      242669   242669           
  Branches     1111     1111           
=======================================
  Hits       241819   241819           
  Misses        829      829           
  Partials       21       21           

@Shinigami92 Shinigami92 requested a review from a team January 27, 2023 16:21
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Jan 27, 2023
@ST-DDT ST-DDT requested a review from a team January 27, 2023 19:35
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to simply retry this test internally a set number of times. Since it all comes down to probability, changing the distribution area will not help in the long run as you can always simply get a 1:0 distribution.

I'll approve this for now since it is a quick "fix".

@Shinigami92
Copy link
Member Author

@xDivisionByZerox Yes, thanks for thinking about that dedicate on our own
Yesterday, @ST-DDT and I, already run these snippets 10 million times to ensure that these boundaries are considered as enough

@Shinigami92 Shinigami92 merged commit 6772b00 into next Jan 28, 2023
@Shinigami92 Shinigami92 deleted the test-widen-trashold-of-array-elements branch January 28, 2023 14:53
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants