-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(company): add realistic Hungarian company names #1758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Can you please add a real world example for all patterns (e.g. a (google) link).
The same for suffixes, alternatively a (wiki) link for verification purposes.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1758 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.02%
==========================================
Files 2337 2340 +3
Lines 242589 242605 +16
Branches 1103 1098 -5
==========================================
- Hits 241737 241721 -16
- Misses 831 863 +32
Partials 21 21
|
You can see the list of real company structure abbreviations on Wikipedia.
The rest of the generation logic is similar to the default: Use a last name to base the name on with these suffixes and additions. Note that in many occasions people tend to omit the terminating dot and stylize some of the abbreviations e.g. "NyRT" instead of "Nyrt.", but using the dot and only capitalising the first one is supposed to be the standard way of writing these abbreviations. Although noone really cares. |
Hungarian company names were generated using Hungarian last names but using English conjunctions and legal forms (such as LLC, Inc) that are invalid for the Hungarian context.
The PR generate realistic company names that would be expected to be seen in the wild.
I've added a very typical Hungarian thing, which was very popular in the past: to include the number "2000" in the names. While it is out of fashion nowadays, many companies still have it in their names, so it makes the generated names very everyday like to have some of those.