Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rimraf to v4 #1744

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 16, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rimraf ~3.0.2 -> ~4.1.0 age adoption passing confidence

Release Notes

isaacs/rimraf

v4.1.0

Compare Source

v4.0.7

Compare Source

v4.0.6

Compare Source

v4.0.5

Compare Source

v4.0.4

Compare Source

v4.0.3

Compare Source

v4.0.2

Compare Source

v4.0.1

Compare Source

v4.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner January 16, 2023 02:04
@renovate renovate bot added the c: dependencies Pull requests that adds/updates a dependency label Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #1744 (bfd6b38) into next (9c47bcc) will not change coverage.
The diff coverage is n/a.

❗ Current head bfd6b38 differs from pull request most recent head 4ba3974. Consider uploading reports for the commit 4ba3974 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1744   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2337     2337           
  Lines      241178   241178           
  Branches     1098     1098           
=======================================
  Hits       240294   240294           
  Misses        863      863           
  Partials       21       21           

Shinigami92
Shinigami92 previously approved these changes Jan 16, 2023
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a "high security" library that can do damage in the wrong hands
So I manually checked the commit messages: isaacs/rimraf@v3.0.2...v4.0.7

As well as specifically:

Everything looks good and there is even now a check that a root folder can not get deleted anymore 👌


@ST-DDT please check also these 3 links and approve

@renovate renovate bot force-pushed the renovate/major-devdependencies branch 3 times, most recently from d588e47 to bc2f280 Compare January 16, 2023 13:47
@ST-DDT
Copy link
Member

ST-DDT commented Jan 17, 2023

I'm a bit confused what you are referring to.
Do you fear it deleting some files it shouldn't?

I looked at the commits and had slight trouble guessing their intent just from the diff.
Let's have a look at them together.

@renovate renovate bot force-pushed the renovate/major-devdependencies branch from bc2f280 to bfd6b38 Compare January 17, 2023 01:00
@Shinigami92
Copy link
Member

Do you fear it deleting some files it shouldn't?

Yes and no, I just saw the major bump and was afraid e.g. they got hacked or whatever
7 bugfix releases (4.0.0 -> 4.0.7) in just few hours + this package was not updated for a long time (nearly 3 years since last release 3.0.2)

I looked at the commits and had slight trouble guessing their intent just from the diff. Let's have a look at them together.

We can approve already, but yeah we can look together when we find a time slot and I can explain some lines of code (knowledge transfer 👍)

@renovate renovate bot force-pushed the renovate/major-devdependencies branch from bfd6b38 to 4ba3974 Compare January 17, 2023 18:11
@Shinigami92 Shinigami92 enabled auto-merge (squash) January 17, 2023 18:14
@Shinigami92 Shinigami92 merged commit cacc968 into next Jan 17, 2023
@renovate renovate bot deleted the renovate/major-devdependencies branch January 17, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants