-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency rimraf to v4 #1744
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1744 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2337 2337
Lines 241178 241178
Branches 1098 1098
=======================================
Hits 240294 240294
Misses 863 863
Partials 21 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a "high security" library that can do damage in the wrong hands
So I manually checked the commit messages: isaacs/rimraf@v3.0.2...v4.0.7
As well as specifically:
Everything looks good and there is even now a check that a root folder can not get deleted anymore 👌
@ST-DDT please check also these 3 links and approve
d588e47
to
bc2f280
Compare
I'm a bit confused what you are referring to. I looked at the commits and had slight trouble guessing their intent just from the diff. |
bc2f280
to
bfd6b38
Compare
Yes and no, I just saw the major bump and was afraid e.g. they got hacked or whatever
We can approve already, but yeah we can look together when we find a time slot and I can explain some lines of code (knowledge transfer 👍) |
bfd6b38
to
4ba3974
Compare
This PR contains the following updates:
~3.0.2
->~4.1.0
Release Notes
isaacs/rimraf
v4.1.0
Compare Source
v4.0.7
Compare Source
v4.0.6
Compare Source
v4.0.5
Compare Source
v4.0.4
Compare Source
v4.0.3
Compare Source
v4.0.2
Compare Source
v4.0.1
Compare Source
v4.0.0
Compare Source
Configuration
📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.