-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(person): add short bio #1696
Conversation
I really like this feature, we should accept it |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1696 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 2242 2245 +3
Lines 240185 240269 +84
Branches 1068 1069 +1
==========================================
+ Hits 239325 239407 +82
- Misses 839 841 +2
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong opinion with this feature 🤔 🤷
I can assume that later there could also be a long version because bios I know are written in multiple lines
This can be extended with options: { format: 'short' | 'long' = 'short' }
or anything like that
|
2/3 I tried to keep the implementation as simple as possible, which means the patterns are a bit more complex (though IMHO still fairly readable). An alternative would be to do more work in code and less in patterns, but i felt that might make future localization harder. |
I was working on some fake user profiles recently using Faker, and one thing I felt was missing which is pretty common on social sites is a user bio.
Had a go at adding some patterns for making bios in this draft PR, using a combination of common bio phrases, nouns and emoji
Not fully tested yet
Here's 100 outputs from
faker.person.bio()