Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(helpers): fake should not trim whitespace #1680

Merged
merged 2 commits into from
Dec 26, 2022
Merged

test(helpers): fake should not trim whitespace #1680

merged 2 commits into from
Dec 26, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 23, 2022

Adds a test that ensures fake() does not trim whitespace.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test m: helpers Something is referring to the helpers module labels Dec 23, 2022
@ST-DDT ST-DDT requested review from a team December 23, 2022 19:51
@ST-DDT ST-DDT self-assigned this Dec 23, 2022
@ST-DDT ST-DDT mentioned this pull request Dec 23, 2022
Merged
@ST-DDT ST-DDT changed the title test: fake should not trim whitespace test(helpers): fake should not trim whitespace Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (next@2f613cf). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4f64379 differs from pull request most recent head 96a189c. Consider uploading reports for the commit 96a189c to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1680   +/-   ##
=======================================
  Coverage        ?   99.64%           
=======================================
  Files           ?     2244           
  Lines           ?   240509           
  Branches        ?     1072           
=======================================
  Hits            ?   239650           
  Misses          ?      838           
  Partials        ?       21

@Shinigami92 Shinigami92 enabled auto-merge (squash) December 26, 2022 11:27
@Shinigami92 Shinigami92 merged commit 5f9f3eb into next Dec 26, 2022
@Shinigami92 Shinigami92 deleted the test/fake/no-whitespace-trim branch December 26, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: test m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox