Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix findname in usage docs #1504

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Oct 31, 2022

fixes #1498

replace faker.person.findName with faker.person.fullName in docs.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1504 (2a98227) into next (284fdcf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1504   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2175     2175           
  Lines      237613   237613           
  Branches     1009     1009           
=======================================
  Hits       236751   236751           
  Misses        841      841           
  Partials       21       21           

@matthewmayer matthewmayer marked this pull request as ready for review October 31, 2022 02:07
@matthewmayer matthewmayer requested a review from a team October 31, 2022 02:07
@matthewmayer matthewmayer requested a review from a team as a code owner October 31, 2022 02:07
@ST-DDT ST-DDT enabled auto-merge (squash) October 31, 2022 09:06
@ST-DDT ST-DDT merged commit 4204a6a into faker-js:next Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs/guide/usage.md references faker.person.findName but no such method exists in v8
3 participants