Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use test snapshots for scripts/apidoc/signature.spec.ts #1488

Merged
merged 9 commits into from
Nov 9, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 25, 2022

Replace the self written snapshot tests with vitest ones.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test labels Oct 25, 2022
@ST-DDT ST-DDT requested review from a team October 25, 2022 20:56
@ST-DDT ST-DDT self-assigned this Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1488 (0499e31) into next (dd58148) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1488      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files        2214     2214              
  Lines      238741   238741              
  Branches     1024     1023       -1     
==========================================
- Hits       237888   237885       -3     
- Misses        832      835       +3     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 92.59% <0.00%> (-0.80%) ⬇️

Shinigami92
Shinigami92 previously approved these changes Oct 25, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) November 4, 2022 16:52
@ST-DDT ST-DDT merged commit 666ff02 into next Nov 9, 2022
@ejcheng ejcheng deleted the test/signature-snapshots branch November 9, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants