Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix fake test expectation #1458

Merged
merged 1 commit into from
Oct 16, 2022
Merged

test: fix fake test expectation #1458

merged 1 commit into from
Oct 16, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 15, 2022

The test uses the following template with fake():

'}}hello{{random.alpha}}'

Starting with v8 the new default for the casing option is mixed, thus the regex has to be updated.

https://next.fakerjs.dev/api/random.html#alpha

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test s: accepted Accepted feature / Confirmed bug m: helpers Something is referring to the helpers module labels Oct 15, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Oct 15, 2022
@ST-DDT ST-DDT self-assigned this Oct 15, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner October 15, 2022 21:20
@ST-DDT ST-DDT requested a review from a team October 15, 2022 21:20
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #1458 (c0874b0) into next (0f9b0c6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1458   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2164     2164           
  Lines      236815   236815           
  Branches      999      999           
=======================================
  Hits       235892   235892           
  Misses        901      901           
  Partials       22       22           

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hu? did I missed that one in #1440 ?

@ST-DDT ST-DDT merged commit 90b9c5c into next Oct 16, 2022
@ST-DDT ST-DDT deleted the fix/fake-tests branch October 16, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants